community: fixed bug in GraphVectorStoreRetriever #27846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
epinzur
force-pushed
the
fix_gvs_retriever
branch
6 times, most recently
from
7723002 to
4dd0b14
Compare
epinzur
force-pushed
the
fix_gvs_retriever
branch
from
4dd0b14 to
81a0b2a
Compare
epinzur
commented
Nov 1, 2024
| @@ -837,8 +838,8 @@ class GraphVectorStoreRetriever(VectorStoreRetriever): | |||
| retriever = graph_vectorstore.as_retriever(search_kwargs={"score_threshold": 0.5}) | |||
| """ # noqa: E501 | |||
|
|
|||
| vector_store: GraphVectorStore | |||
| """GraphVectorStore to use for retrieval.""" | |||
| vectorstore: VectorStore | |||
There was a problem hiding this comment.
changing this from vectorstore to vector_store created the bug.
epinzur
commented
Nov 1, 2024
| @property | ||
| def graph_vectorstore(self) -> GraphVectorStore: | ||
| return cast(GraphVectorStore, self.vectorstore) | ||
|
|
There was a problem hiding this comment.
I had to add this cast property to get the 3.13 lint to pass. If there is a better way to do this, please let me know.
efriis
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
jfyi the community integration tests don't run in CI ever, so might be more effective to add this to the astradb ci instead
dosubot
bot
added
the
lgtm
shjunn
pushed a commit
to shjunn/langchain
that referenced
this pull request
Nov 4, 2024
Description: This fixes an issue that mistakenly created in langchain-ai#27253. The issue currently exists only in `langchain-community==0.3.4`. Test cases were added to prevent this issue in the future. Co-authored-by: Erick Friis <[email protected]>
yanomaly
pushed a commit
to yanomaly/langchain
that referenced
this pull request
Nov 8, 2024
Description: This fixes an issue that mistakenly created in langchain-ai#27253. The issue currently exists only in `langchain-community==0.3.4`. Test cases were added to prevent this issue in the future. Co-authored-by: Erick Friis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes an issue that mistakenly created in #27253. The issue currently exists only in
langchain-community==0.3.4.Test cases were added to prevent this issue in the future.